Use safecast for any downcasting #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrowDom
requested review from
DanielVF,
naddison36,
shahthepro and
clement-ux
as code owners
sparrowDom
changed the base branch from
master
to
sparrowDom/rebaseElsewhere_v2
DanielVF
reviewed
Nov 12, 2024
contracts/contracts/token/OUSD.sol
Outdated
| @@ -277,41 +278,41 @@ contract OUSD is Governable { | |||
| returns (int256 rebasingCreditsDiff, int256 nonRebasingSupplyDiff) | |||
| { | |||
| RebaseOptions state = rebaseState[account]; | |||
| int256 currentBalance = int256(balanceOf(account)); | |||
| uint256 newBalance = (currentBalance + balanceChange).toUint256(); | |||
There was a problem hiding this comment.
Why did this change away from uint256? A balance is a number that can only be positive. It also looks like this changes makes us have to do many more conversions later in the code.
There was a problem hiding this comment.
because of the check on line 283. Though you are right this could be done in a cleaner way. Done here: 21f7eb7
DanielVF
approved these changes
Nov 13, 2024
DanielVF
merged commit 0ab7bc8
into
sparrowDom/rebaseElsewhere_v2
9 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uint256